Inventory to chest event (Red51)

yahwho · Jun 6th 2018

Quick question, I take it there has been a change with the inventory to chest API calls?

Minotorious · Jun 6th 2018

No why? there shouldn't be any change, there was a correction only because the .getItem method and the .getExchangeItem were written inverse and they got fixed to return the correct item.

yahwho · Jun 6th 2018

Hmm. Well. . . on Medieval Realms you can sell items such as gold ingots to the treasury and iron rods etc to the blacksmith.

This works via players transferring items from their inventory into large crates within the shops.

This was all working flawlessly before. We had a server crash a few days ago, and I've just discovered that when players do this action now, the server crashes!

yahwho · Jun 6th 2018

I've only just this second found it out, defiantly a null pointer exception that was not there before. I'll post more info as I find it. . .

Minotorious · Jun 6th 2018

you probably need to switch the .getitem with the .getExchangeItem methods as they were swapped in the last update so if you are using them then there will definitely be a null pointed exception

yahwho · Jun 6th 2018

Hmm well the bit of code I've just tested that's throwing a null pointer is:

Code

if ( event.getExchangeItem().getName().equalsIgnoreCase("IRONROD")) {
//bla bla
}

So are you saying all my getExchangeItem calls need to be changed to getItem? I wonder because you make it sound like its the other way round?

Minotorious · Jun 6th 2018

yes all your .getItem need to become .getExchangeItem and all your .getExchangeItem need to become .getItem

in the old bug version the .getItem returned the exchanged item and the .getExchangeItem returned the item you placed. This was corrected in the last update

yahwho · Jun 6th 2018

Ah that makes sense. Thanks Mino! Saved me a headache there

(panic over)

Also Mino, sorry, I should have read your first reply properly!

Participate now!