Posts by Bamse

Quote from red51

About shearing sheeps, basically this is handled by PlayerNpcInteractionEvent, but I just realized that this is way too limited... this definitely needs some better handling which provides more information about the actual interaction type. Right now it's triggered if you just press F, but it's also triggered when shearing sheeps etc. I will put this on my list (but I'm not sure if this will make it into the next hotfix)!

Here i think about a more generic event like PlayerUseAction. This can be triggered basically when player use equipped item, like rope to leash, shear to shear a shep, knife to skin, knife on tanning rack, bucket to get milk, bucket to get water, etc. and maybe more like use on bread to get half bread, on melon to get slices, etc.

Quote from red51

But maybe I can still get an event (e.g. "PlayerNpcLeashEvent" or smth like that) added with the next hotfix

That will be fantastic!

Quote from red51

Sorry, I forgot to mention this Yes, this bug was indeed fixed with the latest server update, however, it's only fixed on servers. There was no update for the game, so a plugin using this event will work in multiplayer, but not in singleplayer (a fix for the game will probably be available in the next couple of days).

The API event does turn the tanning rack into a (fake) meta object (that's why it's not null), but calling any methods on it won't work...

Not sure about the best solution for now... maybe it would help if the event just had a getRelatedObject() method (which returns the ObjectElement instead of a MetaObject). Or maybe an additional getRelatedObjectDefinition() helps (so getMetaObject() would return null for the tanning rack, but getRelatedObjectDefinition() would still return the tanning rack definition)?

Perhaps it might also work if there was a place target enum provided (which would contain values like "Persistent", "MetaObject", "TanningRack" etc)

Display More

I think on a long run the best is to threat them as metaobject, even if game not supplementary do some processing to them.
On short term probable one enum with target will be very good to know exactly where item is placed (help in future too if other case will appear) and a getRelatedObjectDefinition() to can get definition (where item was placed in tanning rack or gramophone?) for sure is helpful.
And second thing on item pickup (hide,leather,disk) can be do a fake event PlayerItemPickup (cancelable of course)? I see this event is not trigger at all for tanning rack. On place event is triggered, but on pickup no event.

I don't see mention anywhere as issue is fixed, but after server update from yesterday, it seems new event PlayerPlaceItemEvent is fixed!

I test with a few metaobjects:

- Furnace - ok

- drying rack - ok

- oven - ok

- grill - ok

- skewer - ok

- grinder - ok

-paper press - ok

But with tanning rack i encountered a new issue. I don't think is related with first one but same code who works for other station here give error because when i call method to retrieve definition of metaobject, return null if metaobject is a tanning rack!

    @EventMethod
    public void onPlayerPlaceItem(PlayerPlaceItemEvent evt) {
        Player p=evt.getPlayer();
        Item item=evt.getInventoryItem();
        MetaObject station=evt.getMetaObject();
        if (station!=null) {
            // place a item in craft station
            ObjectInfoDefinition def= station.getObjectInfoDefinition();   // <-- Here for tanning rack return null !!!
            Vector3f pos=station.getWorldPosition();
            print("Player %s place a item %s into %s located at coordinate %.2f %.2f %.2f",p.getName(),item.getName(),def.name,pos.x,pos.y,pos.z);
            // Allow other to fill a owner craft station? Why not!
        } else {
            // place a permanent item
            Vector3f pos=evt.getPosition();
            print("Player %s place a persistent item %s at coordinates  %.2f %.2f %.2f",p.getName(),item.getName(),pos.x,pos.y,pos.z);
            // check condition and cancel if not owner or friend with build permissions
            //evt.setCancelled(true);
        }

from log:

[10:49:11] [ADMIN MESSAGE] (Notification) EXCEPTION OCCURRED IN PLUGIN 'TestRw' (AUTHOR: Bamse)         <-- here i put a hide in tanning rack 
-> java.lang.NullPointerException: Cannot read field "name" because "def" is null
    at PLUGIN_CLASS_LOADER//bamse.rw.PermanentItemPlacement2.onPlayerPlaceItem(PermanentItemPlacement2.java:32)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.base/java.lang.reflect.Method.invoke(Method.java:578)
    at net.jiw.unity.runtime.PluginEventHandler.triggerEvent(PluginEventHandler.java:138)
 16711680 
Object tanningrack (2060346) change info 0 -> 745

Note (after more research):

It seems tanning rack is a special object and not a metaobject? Maybe must threat same as a meta object? I can pickup hide from him and no event PlayerPickupItemEvent fired at all! (New event

PlayerPlaceItemEvent is fired).

So no way to know if item (hide or leather) is take from tanning rack or how to deny take item from him on some condition?

Thx

Bamse

BTW. Problem is not particularly with a furnace, but other metaobjects too like grill, oven,etc.

Hi

First thx for adding this new event!

Now i try to use but i hit some issue. For persistent item placement it work as expected, but it is a issue when try to add items on a metabject (furnace, grill). For example when i want to put ore in furnace, ore gone from inventory but on furnace don't appear nothing and i can put in same slot over and over new ore. If i don't use at all new event i can put items in metaobjects! it's like, with new event activated is canceled by default when put items in metaobjects!

For testing purpose i use following code:

package bamse.rw;

import net.risingworld.api.Plugin;
import net.risingworld.api.definitions.Objects.ObjectInfoDefinition;
import net.risingworld.api.events.EventMethod;
import net.risingworld.api.events.Listener;
import net.risingworld.api.events.player.PlayerPickupItemEvent;
import net.risingworld.api.events.player.world.PlayerPlaceItemEvent;
import net.risingworld.api.objects.Item;
import net.risingworld.api.objects.MetaObject;
import net.risingworld.api.objects.Player;
import net.risingworld.api.objects.WorldItem;
import net.risingworld.api.objects.WorldItem.WorldItemType;
import net.risingworld.api.utils.Vector3f;


public class PermanentItemPlacement2 implements Listener {
    protected Plugin plugin=null;    // reference to plugin
    public PermanentItemPlacement2(Plugin testPlugin) {
        this.plugin=testPlugin;
    }

    @EventMethod
    public void onPlayerPlaceItem(PlayerPlaceItemEvent evt) {
        Player p=evt.getPlayer();
        Item item=evt.getInventoryItem();
        MetaObject station=evt.getMetaObject();
        if (station!=null) {
            // place a item in craft station
            ObjectInfoDefinition def= station.getObjectInfoDefinition();
            Vector3f pos=station.getWorldPosition();
            print("Player %s place a item %s into %s located at coordinate %.2f %.2f %.2f",p.getName(),item.getName(),def.name,pos.x,pos.y,pos.z);
            // Allow other to fill a owner craft station? Why not!
        } else {
            // place a permanent item
            Vector3f pos=evt.getPosition();
            print("Player %s place a persistent item %s at coordinates  %.2f %.2f %.2f",p.getName(),item.getName(),pos.x,pos.y,pos.z);
            // check condition and cancel if not owner or friend with build permissions
        }
        
    }
    
    @EventMethod
    public void onPlayerPickupEvent(PlayerPickupItemEvent evt) {
        Player p=evt.getPlayer();
        WorldItem item=evt.getItem();
        WorldItemType type = item.getWorldItemType();
        print("Player %s picked a WorldItem %s of type %s",p.getName(),item.getName(),type.name());
        
        if (item.isPersistent()) {        // type==WorldItemType.PersistentDynamic || type==WorldItemType.PersistentStatic
            // Player take a persistent placed item
            print("   Try to pickup a permanent item placed! Check permission and deny if not a friend with building right!");
            // here cancel event if player don't have right to take permanent item 
        } else if (item.isMetaObjectItem()) { // type==WorldItemType.MetaObject
            // Player take item got from crafting station (furnace,grill,oven,etc.)
            print("   Try to pickup a item from a craft station! Check permission and deny if not a owner or friend with inventory right!");
            MetaObject station = item.getRelatedMetaObject();
            if (station!=null) {
                // I have a craft station
                ObjectInfoDefinition def= station.getObjectInfoDefinition();
                Vector3f pos=station.getWorldPosition();
                print("   Item got from a %s placed at coordinate %.2f %.2f %.2f",def.name,pos.x,pos.y,pos.z);
            }
            // here cancel event if player don't have right to pickup items from crafting stations (furnace,grill,etc.) 
        } else if (type==WorldItemType.Default) {
            print("   Try to pickup a item from ground! It's safe to get dropped item to ground regarding ownership!");
            // player take a item dropped to ground ?
        } else {
            // Other 2 cases:
            //    WorldType==WorldItemType.Attached
            //    WorldType==WorldItemType.Static
            
            // here not sure from what source item come. need more research
            // probable need to cancel if player don't have right
        }
        
    }
    
    // Print to console
    public void print(String s) {
        System.out.println(s);
    }
    
    // Print to console a formated string with a list of arguments 
    public void print(String f, Object... args ) {
        if (f==null) {
            f="";
        }
        print(String.format(f, args));
    }
}

From logs:

[Java] Player Bamse place a item ironore into furnace located at coordinate 1699.72 94.30 1788.76    <--- Here i placed a ore in furnace, but in furnace appear nothing
[Java] Player Bamse picked a WorldItem ironore of type MetaObject                                    <--- here i take a ore from furnace
[Java]    Try to pickup a item from a craft station! Check permission and deny if not a owner or friend with inventory right!
[Java]    Item got from a furnace placed at coordinate 1699.72 94.30 1788.76
Remove item ironore (2032444) from meta object 89067
SERVER: PLAYER Bamse (76561198869958751) PLACED ITEM steakburned @ (1698.98, 93.82, 1784.41)         <--- Here i placed a persistent item
[Java] Player Bamse place a persistent item steakburned at coordinates  1698.98 93.82 1784.41
[Java] Player Bamse picked a WorldItem steakburned of type PersistentStatic                          <--- Here i pickup a persistent item
[Java]    Try to pickup a permanent item placed! Check permission and deny if not a friend with building right!
[Java] Player Bamse picked a WorldItem breadhalf of type Default                                     <--  Here i pickup a dropped item on ground
[Java]    Try to pickup a item from ground! It's safe to get dropped item to ground regarding ownership!

Thx

Bamse

Quote from Devidian

Maybe it'll help you

Thx Devidian for another posibility. But your code don't stop interaction with any animals, not just pickable? But i think that is ok because i don't see a use of interaction with animals beside pickup, yet.

I tried to prevent baby animals pickup on some conditions, But i already solved with PlayerNpcInteractionEvent!

        // list of pickable animals
        List<String> pickableNPC = Arrays.asList("piglet","lamb","goatling","chicken","chick","hare","foxcub","wolfcub");
        
        boolean isPickableNPC(String name) {
            return pickableNPC.contains(name);
        }    

    @EventMethod
        public void onPlayerNPCInteract(PlayerNpcInteractionEvent evt) {
            Player p=evt.getPlayer();
            Npc npc= evt.getNpc();
            NpcDefinition def=npc.getDefinition();
            print("Player %s triggered PlayerNpcInteractionEvent  with a npc %s ",p.getName(),def.name);
            if (isPickableNPC(def.name)) {
                print("Interaction event canceled for pickable animals %s",def.name);
                evt.setCancelled(true);
            } else {
                print("This NPC %s is not a pickable animal! ",def.name);
            }
        }

About breeding of animals.

So far i breed some cows, pigs and horses

- For horse i always i get variant 0 (light brown) even mother are different variants.

- For cow i always get same variant as mother

So question is any got male version of adult from babies get from breeding? Or i was exceptionally unlucky and i got all babies as female variant when they grow, or is something wrong and no male from breeding? Some other player reported same thing, just female.

I make some progress but i don't know how to cancel PlayerMouseButtonEvent (it seems this event don't have setCanceled(true) method ...

But i even if find a method to cancel mouse press button i don't think this is the best approach because left button is used very heavy in game ..

Idealy i want some Event who is triggered on start of special action of equipped item like "Catch Animal", "Shear sheep", etc ...

        @EventMethod
        public void onPlayerSpawn(PlayerSpawnEvent evt) {
            Player p=evt.getPlayer();
            
            // enable mouse listening, otherwise event PlayerMouseEvent don't fire.
            p.setListenForMouseInput(true);
        }
        
        @EventMethod
        public void onMouseButton(PlayerMouseButtonEvent event){
                Player player = event.getPlayer();
                //We only want to process mouse presses (ignore button releases)
                if(event.isPressed()){
                    if(event.getButton() == MouseButton.Left){
                        print ("Player %s press left mouse button button ... ",player.getName());
                        Inventory inv=player.getInventory();
                        Item item= inv.getItem(inv.getEquippedItemSlot() , SlotType.Quickslot) ;
                        if (item!=null) {
                            ItemDefinition def=item.getDefinition();
                            print("  Have a equiped item: %s ",def.name);
                            if ("rope".equals(def.name)) {
                                print("  Rope equiped and try to use left button - animal catch! Check condition and cancel event if required!");
                                // Here i don't know how to cancel mouse button ...
                            }
                        } else {
                            print("  Don't have equiped item!");
                        }
                    }
                }
            }

Hi!

I try to control, via API, when animals can be leashed with a rope. I looked in API but not yet any clue how to detect when a player leash a animal and eventually deny this if some conditions are meet. If any have any hint, that will be very appreciated!

Thx.

Bamse

Hi

If i cancel event PlayerInventoryAddItemEvent when i try to pickup a small animal, it's normal to animal got removed from world, even if i cancel event and in inventory not get Item of category NPC?

@EventMethod
        public void onPlayerEventInventoryAdd(PlayerInventoryAddItemEvent evt) {
            Player p=evt.getPlayer();
            Item item=evt.getItem();
            Origin origin = evt.getOrigin();
            ItemDefinition def=item.getDefinition();
            print("Player %s triggered PlayerInventoryAddItemEvent  with a item %s as category %s from origin %s",p.getName(),item.getName(),def.category,origin.name());
            if (def.category==Items.Category.Npc) {
                // Player add to inventory a NPC (animal)
                evt.setCancelled(true);  // Bug?? animals removed from world and even if i cancel event, animal is destroyed
            }
        }

From logs:

[Java] Player Bamse triggered PlayerInventoryAddItemEvent  with a item chicken as category Npc from origin Pickup
DELETE NPC FROM DB: 1982423

Thx.

Bamse

Hi!

I searched on API events to can interact with item placement / pickup item placed but not find any. They are exist and i missed? Something like:

PlayerItemPermanentPlaceEvent();
PlayerItemPermanentPickupEvent();

If this type of event are not yet in API i can use another solution to detect if player want to place a permanent item and eventually stop it? Same for pickup permanent item?

Maybe another solution can be to extend PlayerPickupItemEvent() with a method to get source of item pickedup.

Source can be:

- Ground - for item dropped on ground

- PermanentItem - for items placed permanently

- CraftStation - For items take from crafting station (ex: ingots / ore from furnace, meat/dried meat from Drying rack, meat/cooked meat from grill/oven, etc.)

- etc.

In meantime maybe is a solution for this problem which i don't see it!

Thx in advance!

Bamse

Quote from red51

Oh, thanks for the update! I think I have an idea what's causing this... I will try to prepare a hotfix for that, but it might still take 1-2 days until it's ready

Nice to know you find a possible solution!

Maybe this will fix too other bug related to crafting station where sometimes objects from inside become invisible, like put some meat/fish on a drying rack and after relog they become invisible. I see same thing to furnace too for example, or oven. This is a old bug who apparently previously update (0.9.1) fixed, but he come back after last update.

BTW:

After last hotfix no blue screen at start of game! Start now with a black screen followed by logo and main menu.

Quote from red51

Which part of the light do you consider too bright exactly? The grass specifically? Or the glare of the sun? Or the overall brightness?

About the moon light, basically it's mainly the direct moonlight that has become brighter (at least it appears brighter)... when walking through a forest, you won't benefit much from it (especially considering that the moon now also casts shadows), so it's still relatively dark there. However, you can also change the brightness of the moon/nights specifically in the game settings

I think the glare of sun is ok, but overall brightness is to strong.
But to change brightness of the moon/nights, don't need first to disable moon phases?

Quote from red51

Hmm... does it only happen after skipping a night? Can you also reproduce this issue in singleplayer (when skipping the night, for example, or when changing the weather)?

I tested on my local server. It seems if i have clouds and sun is rising in the morning FPS have a huge negative impact (50 fps from 120). If i stay more in same place fps slowly come back to 120 (sync with my monitor) after time pass. Problem occur i think between 7am clock
I sent a report too.

I made more test. Fps drop issue appear on clear weather too. For me is from 7:00 to 7:30 when sunrise. Before and after 120 fps, in this time fps drop to 50.

BTW:

After last update i think, at least summer on clear weather, light is to much to texture started to look unnaturally from to much exposure. Personally i like more like before. Maybe increased light during day is too much? I know you made some adjustment for moon/sun light but maybe too strong?. For example night on full moon is so brightness and see almost as day.
Where is my green grass? I know sun can change color, but ... to much.

Hi.

Can we have list of API change log for last version 0.9.1?

Thx

Hi.

First, i thx again red51 for implemented method to reset a chunk via API.

Now come next challenge. I wonder if is possible to obtain from game engine a chunk of unmodified chunk (not actual chunk, but the original default one) and have some method to query about data like:

- What materials contains (stone, ore, coal, air, water,tree, vegetation, etc.).

- If chunks contain object from POI, and list of them (Ex. is involved in a POI/Dungeon generated and have some objects inside)

Example of desired data:

The chunk x,y,z contain :

a) Terrain/ore:

- 200 blocks stone

- 800 blocks air

- 400 blocks of water

- 10 blocks of iron ore

- 30 blocks of gold ore

- etc.

b) Vegetation:

- 2 tree birch

- 2 flower

- 10 fern

- etc.

c) Chunk contain a POI/Dungeon = true

- POI INFO

- etc.

d) Objects (from POI/Dungeons)
- 2 primitive tent
- 1 golden chest
- etc.

This data is required to calculate "value" of chunks. If i give player posibility to reset a chunk i don't want a player to find a "rich" chunk and reset over and over for resources. I want player to pay some resource/currency for resetting chunk and this cost will be more higher than resource from inside so over time if player just reset chunk get a net loss. The scope of reset chunk is not to gather resource over and over but to help restore default generation of chunk and help to quick demolish some complex building, re enable posibility of start spawning again of animal inside, etc.

Thx for any hint how can achieve that.

BTW: Obtaining same data from actual chunk can be a thing too who can be used for other purpose.

I see too FPS drop. For example when night is skipped (hour 0 become 6 am) a few minutes i encounter huge FPS loss (half of FPS) for several minutes. After some time FPS start to rise. Same settings as before update and play on a server.

Quote from Terry McGinn

Love this update! Especially the crossbow and the new clothes!

The rake seems to be behaving like a pickaxe, though.

This. It leave behind a big hole. No matter if used left click or right click to raise terrain. Just one hit to make a big hole and get even the stone/dirt/etc. from terrain.