Bug onPlayerEventInventoryAdd when cancel event when pickup a small animal?

Bamse · 2026-05-12T13:38:23+02:00

Hi

If i cancel event PlayerInventoryAddItemEvent when i try to pickup a small animal, it's normal to animal got removed from world, even if i cancel event and in inventory not get Item of category NPC?

Java

@EventMethod
        public void onPlayerEventInventoryAdd(PlayerInventoryAddItemEvent evt) {
            Player p=evt.getPlayer();
            Item item=evt.getItem();
            Origin origin = evt.getOrigin();
            ItemDefinition def=item.getDefinition();
            print("Player %s triggered PlayerInventoryAddItemEvent  with a item %s as category %s from origin %s",p.getName(),item.getName(),def.category,origin.name());
            if (def.category==Items.Category.Npc) {
                // Player add to inventory a NPC (animal)
                evt.setCancelled(true);  // Bug?? animals removed from world and even if i cancel event, animal is destroyed
            }
        }

From logs:

[Java] Player Bamse triggered PlayerInventoryAddItemEvent  with a item chicken as category Npc from origin Pickup
DELETE NPC FROM DB: 1982423

Display More

Thx.

Bamse

red51 · 2026-05-12T22:59:48+02:00

Yeah, unfortunately cancelling the PlayerInventoryAddItemEvent only prevents the item from being added to the inventory AFAIK this is always the case (e.g also when collecting plants, digging up ores etc)... maybe it's something I could change, but I'm afraid this won't work in all cases (e.g when digging terrain or ores, the items are added after modifying the world, because that's when the game actually knows how many items should be added to the inventory).

However, when picking up baby animals, it should work to listen to the PlayerNpcInteractionEvent. Unfortunately this event does not provide much information... maybe it wouldn't be a bad thing to have a new event for this?

What kind of information do you need (or what are you trying to achieve)?^^

Devidian · 2026-05-12T23:03:29+02:00

I Use this code in my Admin Plugin, and it works fine:

Code

    @EventMethod
    public void onPlayerNpcInteractionEvent(PlayerNpcInteractionEvent event) {
        Npc npc = event.getNpc();
        Player player = event.getPlayer();
        Boolean isAnimal = npc.getDefinition().type == Npcs.Type.Animal;
        // we only want to check for animals
        if (!isAnimal)
            return;
        Vector3i chunkPos = ChunkUtils.getChunkPosition(npc.getPosition());
        Area vArea = AreaUtils.getVirtualAreaFromChunkVector(chunkPos);
        Area area = AreaUtils.isAreaIntersecting(vArea);
        // we only check in areas not in the public world
        if (area == null) {
            return;
        }

        Boolean canInteract = (Boolean) player.getPermissionValue("general_pickupitems", true);

        if (!canInteract) {
            logger().info("Player " + player.getName() + " tried to interact with npc:" + npc.getGlobalID()
                    + " in area " + area.getName() + " (id: " + area.getID() + ") (chunk: " + chunkPos.toString()
                    + ")");
            player.sendTextMessage(t().get("TC_ANIMAL_PROTECTED_INTERACTION", player));
            event.setCancelled(true);
        }
    }

Display More

Maybe it'll help you

Bamse · 2026-05-12T23:05:14+02:00

I tried to prevent baby animals pickup on some conditions, But i already solved with PlayerNpcInteractionEvent!

Java

        // list of pickable animals
        List<String> pickableNPC = Arrays.asList("piglet","lamb","goatling","chicken","chick","hare","foxcub","wolfcub");
        
        boolean isPickableNPC(String name) {
            return pickableNPC.contains(name);
        }    

    @EventMethod
        public void onPlayerNPCInteract(PlayerNpcInteractionEvent evt) {
            Player p=evt.getPlayer();
            Npc npc= evt.getNpc();
            NpcDefinition def=npc.getDefinition();
            print("Player %s triggered PlayerNpcInteractionEvent  with a npc %s ",p.getName(),def.name);
            if (isPickableNPC(def.name)) {
                print("Interaction event canceled for pickable animals %s",def.name);
                evt.setCancelled(true);
            } else {
                print("This NPC %s is not a pickable animal! ",def.name);
            }
        }

Display More

Bamse · 2026-05-12T23:16:46+02:00

Quote from Devidian

Maybe it'll help you

Thx Devidian for another posibility. But your code don't stop interaction with any animals, not just pickable? But i think that is ok because i don't see a use of interaction with animals beside pickup, yet.

Devidian · 2026-05-12T23:19:41+02:00

Quote from Bamse

Thx Devidian for another posibility. But your code don't stop interaction with any animals, not just pickable? But i think that is ok because i don't see a use of interaction with animals beside pickup, yet.

yes because my plugin checks only area and user permissions, goal is that no stranger can do any interaction with animals on a players property. In the wilderness no checks are made

Participate now!