PlayerChestToInventoryEvent with invetory.removeItem(****) not working as expected

Minotorious · May 12th 2017

I have this very simple set of java commands to delete any dynamite upon pickup from chests (i.e. to avoid getting dynamite in the server through the shack chests) but it is not really working, I can just pick the dynamite and place it in my inventory without any problems, in spite of that I get the message I have set for it to send "tnt removed!", any thoughts

Java

@EventMethod
    public void onItemPickUpFromChest(PlayerChestToInventoryEvent event){
        Player player = event.getPlayer();
        Item item = event.getItem();
        if (item.getName().equals("tnt")){
            int slot = event.getInventorySlot();
            SlotType slottype = event.getInventorySlotType();
            player.getInventory().removeItem(slot,slottype);
            player.sendTextMessage(item.getName() + " removed!");
        }
    }

Display More

red51 · May 12th 2017

If you want to prevent the player from picking up an item from a chest, you have to cancel the event by calling event.setCancelled(true);. Usually most events are triggered right before the particular action happens, so in this case, the event is called when the item is about to be moved from the chest to the inventory (but the item is still in the chest, not in the inventory). If the event does not get cancelled, the game will proceed with moving the item from the chest to the inventory. So if you want to stop the game from processing a certain action, you have to cancel the particular event

Minotorious · May 12th 2017

i tried that but then the item remains in the chest, while I want to make it disappear.

red51 · May 12th 2017

Usually the best approach to achieve that would be to cancel the event, and then remove the item from the chest. However, unfortunately the API does not provide any access to chests currently, probably that will be added with the next update. As a workaround (but that's a dirty solution) you could create a timer and remove the item from the inventory with a small delay, e.g.:

Java

@EventMethod
public void onItemPickUpFromChest(PlayerChestToInventoryEvent event){
    Player player = event.getPlayer();
    Item item = event.getItem();
    if(item.getName().equals("tnt")){
        Timer timer = new Timer(0f, 2f, 0, () -> {
            player.getInventory().removeItem(event.getInventorySlot(), event.getInventorySlotType());
            player.sendTextMessage(item.getName() + " removed!");
        });
        timer.start();
    }
}

Display More

This should work, however, this isn't a good solution. I'd recommend to wait for appropriate methods to access chests

Minotorious · May 12th 2017

hmm yes I was looking for a method to delete the item in the chest but as you said there isn't one yet. haha 2 second timer nice workaround but if they know and manage to move it before the timer hits then we get a null pointer exception and they keep the dynamite

I would like an Item.destroy() method like for the WorldItems if possible to tackle this better (as expressed here: Item.destroy() method similar to WorldItem.destroy()) or the chest specific methods when you create them

my current workaround will probably be to cancel the event and if they try to destroy the chest to pick up the item use the PlayerInvetoryAddEvent to remove the item completely.

red51 · May 12th 2017

Quote from Minotorious

haha 2 second timer nice workaround but if they know and manage to move it before the timer hits then we get a null pointer exception and they keep the dynamite

That's true... yeah well the timer is indeed a dirty solution. It's better to cancel the event, this way the player isn't able to get the item

Quote from Minotorious

my current workaround will probably be to cancel the event and if they try to destroy the chest to pick up the item use the PlayerInvetoryAddEvent to remove the item completely.

If you cancel the PlayerChestToInventoryEvent and the PlayerInventoryAddEvent, the player has no chance to obtain the dynamite from a chest. Even if the item remains in the chest after cancelling the PlayerChestToInventoryEvent, the player isn't able to get the item If he destroy the chest, he still cannot pickup the item (if you cancel the PlayerInventoryAddEvent), and after a given amount of time (or after a restart), the item disappears anyway (like any world items)

Participate now!