I don't understand the New API Update

King Nothing · Jan 23rd 2018

Red, could you kindly explain what the KillNPC Event does?

Ive been playing with it and Tried to get it to Show the player name with no luck, Ive Tried casting player to the event and Still Nothing

How do I get the player name out of:

String TheKiller= (String) event.getKiller(); ?

the event seems limited at the moment

Minotorious · Jan 23rd 2018

well first of all the event is called NpcDeathEvent so you just need to create an @EventMethod method of this event to intercept all things related to it. Something like this:

Java

@EventMethod
public void NPCDeathEvent (NpcDeathEvent event){
    Player player = event.getkiller()
    getServer().broadcastTextMessage("Killer: " + player.getName())
}

King Nothing · Jan 23rd 2018

it would help If I didn't forget "@EventMethod" every time i use an new event,too and "Player" cannot be called Within the event. thatis wht I ay its Limited and don;t know what to do woth it.

I get j.c Cannoft be cast to rsingworld.net.objects.player, nothing comes out in the debug console.

red51 · Jan 23rd 2018

The getKiller() function of the NpcDeathEvent does not necessarily return a player (see javadoc). It returns an Object which can be null if the npc wasn't killed by a player. Ideally you have to check if there is a killer and if the killer is actually a player (and if it's an instance of Player, you need to cast the result):

Java

@EventMethod
public void onNpcDeath(NpcDeathEvent event){
    if(event.getKiller() != null && event.getKiller() instanceof Player){
        //npc was killed by a player
        Player player = (Player) event.getKiller();
    }
    else{
        //npc wasn't killed by a player (e.g. npc drowned etc)
    }
}

King Nothing · Jan 23rd 2018

thanks, yeah, one thing.. I used

player.sendtextMessage("Killed it");
and Nothing Hapened.

yahwho · Feb 3rd 2018

Here is my test method for this.

Code

@EventMethod
    public void onNpcDeath(NpcDeathEvent event) {

      System.out.println(PREFIX + "NPC Death Event called. . .");

      if (event.getKiller() == null ) System.out.println(PREFIX + "NPC killed by a null object"); 

      if (event.getKiller() != null ) System.out.println(PREFIX + "NPC killed by an object"); 

      if (event.getKiller() instanceof Player ) { 
          System.out.println(PREFIX + "NPC was killed by a player");
      } else {        
          System.out.println(PREFIX + "NPC was NOT killed by a Player");
      }

Display More

Now, when I kill a NPC (with an axe, if that matters) in game the log shows:

Code

Loaded Worldpart (v3) from cache: -1 - 0  (129ms)
< < < <  MEDIEVAL REALMS  > > > > Player Spawned. . . 
< < < <  MEDIEVAL REALMS  > > > > NPC Death Event called. . .
< < < <  MEDIEVAL REALMS  > > > > NPC killed by an object
< < < <  MEDIEVAL REALMS  > > > > NPC was NOT killed by a Player
NPC (ID: 131) deleted!

Which implies it's not an instance of a Player object?

noci · Feb 3rd 2018

may be like:

Java

if (event.getKiller().getClass().equals(net.risingworld.api.objects.Player.class)){
    System.out.println(PREFIX + "NPC was killed by a player");
    Player ply = (Player)event.getKiller();
}
if (event.getKiller().getClass().equals(net.risingworld.api.objects.Npc.class)){
    System.out.println(PREFIX + "NPC was killed by a npc");
    Npc npc = (Npc)event.getKiller();
}

yahwho · Feb 4th 2018

Thanks noci I'll give that a go soon. I've been somewhat sidetracked with linked lists at the moment ( admittedly it may be overkill but I'm trying to think long term )

red51 · Feb 4th 2018

It looks like an issue in the API, the wrong player instance was used (so it was never an instance of the "Player" object). This will be fixed with the next update

yahwho · Feb 4th 2018

Awesome great API really getting me back into coding!

Participate now!