Servers automatically renaming Plugin Database

Ah well just a thought, I was always taught to use escape backslashes.

An odd problem Indeed.

( Edits due to butter fingers )

Sql should be giving you errors if there are problems?

Maybe the queries are wrong? Using update statements without inserts? Sorry not going to be much help here.

Quote from yahwho

Ah well just a thought, I was always taught to use escape backslashes.

I think front slashes already take account of this thus you don't need the escape character on backslashes. i.e. / and \\ are equivalent characters in a file path string.

Quote from yahwho

Sql should be giving you errors if there are problems?

This is true if the queries happen and are failing there should be SQL exceptions thrown, and if caught by the plugin itself there should be an error message appearing if the plugin creator has coded one in.

Quote from yahwho

Maybe the queries are wrong? Using update statements without inserts? Sorry not going to be much help here.

I will have a look at the decompiled code again to check but no way to know for certain without the full source code

Second post in a row but I just checked the decompiled code again and I think I see the problem.

In the SQL statements it is recommended to use the keyword LIKE instead of an equals = sign because in some systems that causes problems, also in the SQL statements again there are single quotes ` instead of '. I would recommend removing the single quotes all together since many systems confuse them and don't recognise table names if they are in single quotes.

Something else I noticed is that the iConomy plugin is not using prepared statements for its SQL statements, that doesn't cause problems but it is not a good practice since a player could use an SQL Injection attack to alter anything they wanted in the database.

Quote from angriff

It does not seem to recognize short single player UIDs versus Steam

both steam and standalone players have a type long UID. Unless you mean something else by that?

As I said the plugin probably has bugs in it as it is still in development, I would recommend only using it for testing purposes and to provide feedback to the developer, it is clearly not ready for players to play with.

Yes, its called a SQL injection attack.

Link to some info:

https://www.acunetix.com/websitesecurity/sql-injection/

It all depends on how the application is written as to whether there is a vulnerability or not.

On a basic level you can execute extra commands. Like drop table or add extra table info / modifications.

I can not resist adding my mustard!
1. Do not use hardcoded path name separators! Not "/" and not "\\"!

Please make use of the getSeparator()-function:

String SEP = FileSystems.getDefault().getSeparator();
String filePath = plugin.getPath() + SEP + "data" + SEP + "mydatabasefile.db";

2. Avoiding SQL injection attacks: always use prepared statements and then everything is in the paint again!

Prepared Statement Example: (excerpt from abm rancher update routine)

try(PreparedStatement prep = connection.prepareStatement(
      "UPDATE rancher SET playerName=?, offspringCounter=?, rewardCounter=? WHERE PlayerId=?;"))
    {
      connection.setAutoCommit(false);
      for(Rancher rancher : list)
      {
        prep.setString(1, rancher.getPlayerName());
        prep.setInt(2, rancher.getOffspringCounter());
        prep.setInt(3, rancher.getRewardCounter());
        prep.setInt(4, rancher.getPlayerId());
        prep.addBatch();
      }
      prep.executeBatch();
      connection.commit();
    }

Happy coding!

Quote from Machete

I can not resist adding my mustard!
1. Do not use hardcoded path name separators! Not "/" and not "\\"!

Please make use of the getSeparator()-function:

Java

String SEP = FileSystems.getDefault().getSeparator();
String filePath = plugin.getPath() + SEP + "data" + SEP + "mydatabasefile.db";

As far as I am aware you only need to use the .getSeparator() function if you are using the code on a JVM with multiple partitions each with its own filesystem. If you are using a single JVM then a / is translated to the filesystem's default. I don't think I am wrong but am I?

You are not wrong! It is normalized, f.e. when using java.io new File("a/b/c").
But on the other hand there are cases where you pass a path with no normalization (native libraries?) when the target system is unknown.
I simply do not want to care about this.

Quote from Machete

I simply do not want to care about this.

fair point

Lol! Or we could even use path . . .

...now we are talking!