possable bug with EventMethods?

james1bow · Apr 15th 2023

i have been toying a little with the api and have run across an issue. when using any EventMethods i get errors and it doesnt work when being used on my server. plugin works as expected in single player. sorry in advance if its just me!

Java

package rwtest1;

import net.risingworld.api.*;
import net.risingworld.api.events.Listener;

public class Rwtest1 extends Plugin implements Listener{

   //Player player;
   Plugin plugin;
   
   
    @Override
    public void onEnable() {
        MyListener lt = new MyListener(plugin);
        registerEventListener(lt);
        
    }

    @Override
    public void onDisable() { 
        
    }

    
}

Display More

Java

package rwtest1;

import net.risingworld.api.Plugin;
import net.risingworld.api.events.EventMethod;
import net.risingworld.api.events.Listener;
import net.risingworld.api.events.player.PlayerConnectEvent;
import net.risingworld.api.events.player.PlayerKeyEvent;
import net.risingworld.api.objects.Player;
import net.risingworld.api.utils.Key;


public class MyListener implements Listener{
    
    
    private Plugin plugin;
    
    
    
    public MyListener(Plugin plugin){
        this.plugin = plugin;
    }
    
    
    @EventMethod
    public void keyInput(PlayerKeyEvent evt) {
        Player player = evt.getPlayer();
        if(evt.isPressed()){
            if(evt.getKey() == Key.U){
                player.sendTextMessage("<color=red>test text");
            }
        }
    }
    
    
    @EventMethod
    public void onPlayerConnect(PlayerConnectEvent evt){
        Player player = evt.getPlayer();
        player.setListenForKeyInput(true);
        player.registerKeys(Key.U);
    }
    
    
    
}

Display More

noci · Apr 15th 2023

Also ich arbeite derzeit nur für Server und habe in der Sub-Class:

---

So I'm currently only working for servers and have in the sub-class:

Code

public MyListener(Plugin plugin){
    this.plugin = plugin;
    plugin.registerEventListener(this);
}

Das klappt ohne Fehler

---

This works without errors

Dann aber auch ohne diese Zeile

---

But then also without this line

Code

@Override
public void onEnable() {
    MyListener lt = new MyListener(plugin);
    registerEventListener(lt);
}

Aber ob das nicht auch so gehen soll wie du das gemacht hast, weiß ich nicht, vieleicht ist das doch ein fehler

---

But I don't know whether it shouldn't work the way you did it, maybe that's a mistake

red51 · Apr 15th 2023

That code should basically work, at least it worked on my end (pressing U printed a red text to the chat) The only "issue" is that "plugin" (line 14 of the first snippet) is null (because the "plugin" variable has never been initialized), that doesn't matter in this code (because that parameter isn't used in the snippet anyway), but probably this was unintended?

It's weird if this only works in singleplayer, but not on the server Could you maybe send me the full server log (either post it here, or send it via PM to me)?

yahgiggle · Apr 15th 2023

i tested it my way and also have 100% the same problem as James, works fine in single player, but not if used on a server

red51 · Apr 16th 2023

Thanks for the log james1bow ! It looks like the PlayerKeyEvent isn't triggered correctly in multiplayer We will fix that ASAP! Other events should work fine though

james1bow · Apr 16th 2023

Quote from red51

Thanks for the log james1bow ! It looks like the PlayerKeyEvent isn't triggered correctly in multiplayer We will fix that ASAP! Other events should work fine though

Thanks you! i had had a lot more in there and removed it trying to figure out what was going on. That's why the initialized plugin variable was still there.

.

yahwho · Apr 16th 2023

Not a biggie James, but when you use colour XML syntax it should be closed too afaik.

Code

player.sendTextMessage("<color=red>test text</color>");

james1bow · Apr 16th 2023

Quote from yahwho
Not a biggie James, but when you use colour XML syntax it should be closed too afaik.
Code
player.sendTextMessage("<color=red>test text</color>");

thanks for the reminder!

Participate now!