Economy plugin

Good job @notabadminer! May I raise a few details?

1) Is there a reason for using the world database as database? I understand this simplify some things, but I would refrain from 'polluting' the world database as, for instance, if something goes wrong there is a risk of corrupting the whole world and who knows if in the future the dev team adds a new table with the same name of one of yours table?

2) I have not tried the plug-in yet, just browsed the code. Are you sure i18n works by simply dropping a language file in the plug-in directory? The code reads the language file from the resources and this requires the language file to be in the .jar.

3) If am not mistaken, the code reads each localised string from the resources each time it is needed. This seems a waste of storage and CPU usage. As currently there are only about 20 strings (and there might be a few more in the future but not hundreds and hundreds) and RW only supports two languages, I would pre-load all the strings at plug-in start in an array / container and then access the needed one from memory.

3b) Same for built-in default strings, which are all loaded each time one is needed: these are a rather obvious candidate for pre-loading.

4) I am not sure that localising commands is a good thing, as this may require that players learn new commands for the same things when switching from one server to another.

5) Also about commands, commands with very generic names like "/buy" and "/sell" are likely to clash with other plug-ins implementing some kind of buying and selling. My approach is to use a plug-in specific prefix for all commands, as for instance "/econ buy ...", "/econ sell ..."

Quote from notabadminer

1) I used the world database out of ease of implementation. I will look into changing to a separate database.

As we are speaking of just two tables with at most a couple of hundreds of rows each, there are little reasons for not using SQLite, which is simple, fast and easy. Using a plug-in specific SQLite DB is just a matter of replacing

WorldDatabase database = getWorldDatabase();

with

Datatase database = getSQLiteConnection(getPath() + "/myDBname.db");

or, if you want to have a separate DB for each world (mostly for use with single player installations, where multiple worlds normally coexist):

Datatase database = getSQLiteConnection(getPath() + "/myDBname-" + getWorld().getName()+".db");

I would use database as a class field, so that you can open it at plug-in start-up (onEnable()) and close it at plug-in close-down (onDisable()) and have it ready to use any time you need it (database.executeQuery(...);, database.executeUpdate(...);, etc).

About the other points, I see you have quickly found a solution. Great!

Is there an easy way to clear all prices and make them manually only for those items that I need? I can export a pricelist. And change values to -1. But there are hundreds of strings.

May be you have a clean pricelist?

This plug-in is ready or is still being worked on ?

Quote from lenko

This plug-in is ready or is still being worked on ?

It works fine

is there a way to have an account statement for accounting purposes? also how do you send credits from 1 account to another? and can we get this to read and wright to the bank .db file for the bank plugin?

really happy to see this being done, when I get time am adding to our server

Is this Plugin update? Because UID?

I don't think this has been updated in quite a while. Last time the creator was online on the forum was May 6th 2017, so almost a year ago

Ok, help please

I know this thread is cold, but I have been trying out the plugin. So to those who might be using it.

Do you have to set all the prices for goods? As the plugin when I have run it returns the message, NO PRICE FOR '......' when '.....' is any item? I see a csv file in the zip that accompanies the jar file but when the zip is opened this ends up in a subfolder of a subfolder. Now my programming skills are as about accomplished as my acrobatic skills on a trapeze, which means if I try to do acrobatics on a trapeze I would end up as a puddle of goo and bones on the floor. So I'm guessing the csv file is not being read or I have to place it somewhere else?

Quote from Smudger

Ok, help please

I know this thread is cold, but I have been trying out the plugin. So to those who might be using it.

Do you have to set all the prices for goods? As the plugin when I have run it returns the message, NO PRICE FOR '......' when '.....' is any item? I see a csv file in the zip that accompanies the jar file but when the zip is opened this ends up in a subfolder of a subfolder. Now my programming skills are as about accomplished as my acrobatic skills on a trapeze, which means if I try to do acrobatics on a trapeze I would end up as a puddle of goo and bones on the floor. So I'm guessing the csv file is not being read or I have to place it somewhere else?

I just recently installed this plugin, but so far I have found that only some of the items have prices by default. I had the same question you did, so I downloaded the source code and found that the .csv file inside the jar file is only used to populate a database the first time you start with the plugin, or I guess if you do an import. Also, if that .csv file is not in the jar file, it will also look for a .csv file with the same name inside the plugin directory. Once the database is initialized, you can use a SQLITE database tool to modify the pricelist table, or I suppose you could delete that database file, modify the .csv file and then restart and it should import all the prices. This would lose account balances for all players though.

I ended up modifying the code a bit to allow any player to transfer money to another player and have it deduct from their account and credit the recipient.

Hope that helps.

Trint

It needs to be updated for UID reference not name reference for the general reasons for this. The autologon account setup was not functioning in my server so you have to sell something for the account to show up. I have done a minor patch that allowed that as well as transfer between people if you need it contact me. It is functional, if rather crude, as I am not an expert Javasmith by any stretch of the words.

There is a command for exporting and importing a .csv file that you can edit the prices. It is an admin command. /economy export and /economy import. The file has to be .csv but you can edit it in Excel or a good text editor. The price item list is woefully out of date. You will have to update this with new items such as saddles or saddlebags.

Hi ! Thanks a lot for this plugin ! Rising world is SO GREAT and with your plugin it can become AMAZING

But i've got problems with it

When i type /egivecoins 1 toto it tell me "Invalid Amount!" and i got coins in my wallet

What's wrong with my command please ?

Thanks a lot !

The problem is most likely not with your command but with the fact that this plugin hasn't been updated in more than a year with 2 major updates changing a lot of things in the game and Java API in that year.

tl;dr this plugin most likely doesn't fully function anymore

I will cry ! Thanks for this answer

Is there another plugin to setup price and commerce system in the game ??

Try

[Plugin] iConomy 1.3.0 (Geld-Plugin mit GUI) | (Money Plugin with GUI)